Conversation
mwcz
approved these changes
Aug 6, 2018
Contributor
mwcz
left a comment
mwcz
left a comment
There was a problem hiding this comment.
"Loud Gerrard" Teaches Miming
I do think if we start to use the action system more, it would be good to consolidate the action handlers in one spot. I would prefer this.actionHandlers.setProperty vs this._setProperty, but the latter is perfect for now. Not worth the work unless the number of action handlers grows a lot.
starryeyez024
added a commit
that referenced
this pull request
Aug 15, 2018
* rh-cta: Removing call to breakpoint-sass that broke npm run build. Works now. Fixing some var assignment bugs in RH-CTA test pr and add cta type select box (#102) adding the ability to set the rh-type attribute (#101) switching from .compiled.js to .umd.js (#100) Adding licenses (#99) Moving CP Theme to a new themes dir (#94) # Conflicts: # elements/rh-cta/demo/index.html # elements/rh-cta/rh-cta.compiled.js # elements/rh-cta/rh-cta.js # elements/rh-cta/src/rh-cta.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52